Remove hardcoded styling and unused colors from DiffRenderer#8
Open
paololeonardi wants to merge 1 commit intotornikegomareli:mainfrom
Open
Remove hardcoded styling and unused colors from DiffRenderer#8paololeonardi wants to merge 1 commit intotornikegomareli:mainfrom
paololeonardi wants to merge 1 commit intotornikegomareli:mainfrom
Conversation
Drops fixed padding, the hardcoded ScrollView background, and the now-unused Color.appBackground / PlatformColors, letting consumers control spacing and background inheritance themselves.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (4)
📝 WalkthroughWalkthroughThe pull request removes the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes opinionated layout defaults baked into
DiffRendererso that consumers have full control over spacing and background appearance.Fixes dark-corner artifacts that appeared when the view was embedded in a grouped
Listin dark mode.Changes
.padding()fromDiffRenderer— callers apply it externallyColor.appBackgroundfrom theScrollViewbackground, letting the view inherit its container's backgroundPlatformColors.swiftand the now-unusedColor.appBackgroundextension, along with theimportreferences inDiffFileViewandDiffLineViewBreaking Changes
Consumers that relied on
DiffRenderer's built-in padding will need to add.padding()at the call site.Testing
Verified manually by embedding
DiffRendererin a groupedListin both light and dark mode — no background artifacts observed.Summary by CodeRabbit